Fix #302114: Wrong default GUI font under Windows #5791
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jojo-Schmitz
reviewed
Mar 8, 2020
Jojo-Schmitz
reviewed
Mar 8, 2020
Jojo-Schmitz
reviewed
Mar 8, 2020
Spire42
force-pushed
the
#302114-wrong-default-GUI-font-under-Windows
branch
from
2d5f165 to
0d77752
Compare
Jojo-Schmitz
reviewed
Mar 8, 2020
Spire42
force-pushed
the
#302114-wrong-default-GUI-font-under-Windows
branch
from
0d77752 to
e9d9fce
Compare
Worked around a problem in Qt that caused MuseScore to use the wrong default GUI font on Windows. Qt 5.x and below use the deprecated function GetStockObject() with DEFAULT_GUI_FONT, which returns MS Shell Dlg 2 in 8 pt. MS Shell Dlg 2 is a virtual font that maps to Tahoma, which has not been the default Windows GUI font since 2006. The correct way to determine the default GUI font is to call SystemParametersInfoW() with SPI_GETNONCLIENTMETRICS and use the returned lfMessageFont structure. On all versions of Windows from Windows Vista through Windows 10, this typically returns Segoe UI in 9 pt. This problem is slated to be fixed in Qt 6, For details, see: https://bugreports.qt.io/browse/QTBUG-58610 In the meantime, we can work around the problem by having Qt use the "QMessageBox" font instead, which is already being initialized the correct way. There are two parts to this fix: 1. Override Qt's detection of the default GUI font. To do this, we ask Qt for the "QMessageBox" font and then tell Qt to use that as the default GUI font as well. 2. Detect existing settings files that have been saved with the incorrect default GUI font, and reset the incorrect font settings so that the correct font can be picked up automatically by existing MuseScore installations. Note that this will have the side effect of making the MS Shell Dlg 2 font no longer “stick” if the user explicitly selects it. However, this is a virtual placeholder font that shouldn't be explicitly selected anyway, and any users who prefer its look can always explicitly select the actual underlying font, Tahoma.
Spire42
force-pushed
the
#302114-wrong-default-GUI-font-under-Windows
branch
from
e9d9fce to
9ddc8ce
Compare
|
I did some more digging and I found a better workaround. It turns out that there's already an existing code path in the Qt codebase that's initializing fonts the correct way; specifically, it's the code in I've just updated the code in this PR with this better workaround. |
Jojo-Schmitz
reviewed
Mar 9, 2020
8 tasks
|
Refiled as #5820. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #302114
Worked around a problem in Qt that caused MuseScore to use the wrong default GUI font on Windows. Qt 5.x and below use the deprecated function
GetStockObject()withDEFAULT_GUI_FONT, which returns MS Shell Dlg 2 in 8 pt. MS Shell Dlg 2 is a virtual font that maps to Tahoma, which has not been the default Windows GUI font since 2006.The correct way to determine the default GUI font is to call
SystemParametersInfoW()withSPI_GETNONCLIENTMETRICSand use the returnedlfMessageFontstructure. On all versions of Windows from Windows Vista through Windows 10, this typically returns Segoe UI in 9 pt.This problem is slated to be fixed in Qt 6. For details, see QTBUG-58610.
In the meantime, we can work around the problem by having Qt use the
"QMessageBox"font instead, which is already being initialized the correct way.There are two parts to this fix:
Override Qt's detection of the default GUI font. To do this, we ask Qt for the
"QMessageBox"font and then tell Qt to use that as the default GUI font as well.Detect existing settings files that have been saved with the incorrect default GUI font, and reset the incorrect font settings so that the correct font can be picked up automatically by existing MuseScore installations. Note that this will have the side effect of making the MS Shell Dlg 2 font no longer “stick” if the user explicitly selects it. However, this is a virtual placeholder font that shouldn't be explicitly selected anyway, and any users who prefer its look can always explicitly select the actual underlying font, Tahoma.